Fixed implicit widening multiplication error, Removed unused "this", Fixed narrowing conversion, Made m_verified and m_invalid mutable, Removed else-after-return, Removed unused num_full_blocks and last_block_size var all to make clang-tidy happy

This commit is contained in:
Matt Hess
2025-12-18 00:52:40 +00:00
parent 9266f28d22
commit 4ddfa22d1b
8 changed files with 75 additions and 49 deletions

View File

@@ -23,11 +23,20 @@ jobs:
cd external/src/curl
cmake . -DCMAKE_BUILD_TYPE=Release -DBUILD_CURL_EXE=OFF -DBUILD_SHARED_LIBS=OFF -DCURL_DISABLE_INSTALL=ON -DHTTP_ONLY=ON -DCURL_ENABLE_SSL=OFF
make -j$(nproc)
cd ../libuv
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=OFF -DLIBUV_BUILD_TESTS=OFF
make -j$(nproc)
cd ../../libzmq
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=OFF -DWITH_LIBSODIUM=OFF -DBUILD_TESTS=OFF
make -j$(nproc)
cd ../../..
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release -DSTATIC_BINARY=ON -DWITH_LTO=OFF
make -j$(nproc)
make -j$(nproc) p2pool-salvium
strip p2pool-salvium
./p2pool-salvium --test
- name: Package
run: |
@@ -62,11 +71,20 @@ jobs:
cd external/src/curl
cmake . -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS="-Os -flto=auto" -DBUILD_CURL_EXE=OFF -DBUILD_SHARED_LIBS=OFF -DCURL_DISABLE_INSTALL=ON -DHTTP_ONLY=ON -DCURL_ENABLE_SSL=OFF
make -j$(nproc)
cd ../libuv
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS="-Os -flto=auto" -DBUILD_SHARED_LIBS=OFF -DLIBUV_BUILD_TESTS=OFF
make -j$(nproc)
cd ../../libzmq
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_FLAGS="-Os -flto=auto" -DBUILD_SHARED_LIBS=OFF -DWITH_LIBSODIUM=OFF -DBUILD_TESTS=OFF
make -j$(nproc)
cd ../../..
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release -DSTATIC_BINARY=ON -DWITH_LTO=OFF
make -j$(nproc)
make -j$(nproc) p2pool-salvium
strip p2pool-salvium
./p2pool-salvium --test
tar -czf p2pool-salvium-v${{ inputs.version }}-linux-aarch64.tar.gz p2pool-salvium
- uses: actions/upload-artifact@v4
@@ -96,11 +114,20 @@ jobs:
cd external/src/curl
cmake . -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS="-Os" -DBUILD_CURL_EXE=OFF -DBUILD_SHARED_LIBS=OFF -DCURL_DISABLE_INSTALL=ON -DHTTP_ONLY=ON -DCURL_ENABLE_SSL=OFF
make -j$(nproc)
cd ../libuv
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS="-Os" -DBUILD_SHARED_LIBS=OFF -DLIBUV_BUILD_TESTS=OFF
make -j$(nproc)
cd ../../libzmq
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_FLAGS="-Os" -DBUILD_SHARED_LIBS=OFF -DWITH_LIBSODIUM=OFF -DBUILD_TESTS=OFF
make -j$(nproc)
cd ../../..
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release -DSTATIC_BINARY=ON -DWITH_LTO=OFF
make -j$(nproc)
make -j$(nproc) p2pool-salvium
strip p2pool-salvium
./p2pool-salvium --test
tar -czf p2pool-salvium-v${{ inputs.version }}-linux-riscv64.tar.gz p2pool-salvium
- uses: actions/upload-artifact@v4
@@ -123,9 +150,10 @@ jobs:
make -j$(sysctl -n hw.ncpu)
cd ../../..
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release
make -j$(sysctl -n hw.ncpu)
cmake .. -DCMAKE_BUILD_TYPE=Release -DSTATIC_LIBS=ON -DWITH_LTO=OFF
make -j$(sysctl -n hw.ncpu) p2pool-salvium
strip p2pool-salvium
./p2pool-salvium --test
tar -czf p2pool-salvium-v${{ inputs.version }}-macos-x64.tar.gz p2pool-salvium
- uses: actions/upload-artifact@v4
@@ -148,9 +176,10 @@ jobs:
make -j$(sysctl -n hw.ncpu)
cd ../../..
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release
make -j$(sysctl -n hw.ncpu)
cmake .. -DCMAKE_BUILD_TYPE=Release -DSTATIC_LIBS=ON -DWITH_LTO=OFF
make -j$(sysctl -n hw.ncpu) p2pool-salvium
strip p2pool-salvium
./p2pool-salvium --test
tar -czf p2pool-salvium-v${{ inputs.version }}-macos-aarch64.tar.gz p2pool-salvium
- uses: actions/upload-artifact@v4
@@ -181,9 +210,10 @@ jobs:
make -j$(nproc)
cd ../../..
mkdir build && cd build
cmake .. -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release
make -j$(nproc)
cmake .. -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release -DSTATIC_LIBS=ON -DOPENSSL_NO_ASM=ON -DWITH_LTO=OFF
make -j$(nproc) p2pool-salvium
strip p2pool-salvium.exe
./p2pool-salvium.exe --test
zip p2pool-salvium-v${{ inputs.version }}-windows-x64.zip p2pool-salvium.exe
- uses: actions/upload-artifact@v4