674 lines
30 KiB
C++
674 lines
30 KiB
C++
// Copyright (c) 2023-2024, The Monero Project
|
|
//
|
|
// All rights reserved.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without modification, are
|
|
// permitted provided that the following conditions are met:
|
|
//
|
|
// 1. Redistributions of source code must retain the above copyright notice, this list of
|
|
// conditions and the following disclaimer.
|
|
//
|
|
// 2. Redistributions in binary form must reproduce the above copyright notice, this list
|
|
// of conditions and the following disclaimer in the documentation and/or other
|
|
// materials provided with the distribution.
|
|
//
|
|
// 3. Neither the name of the copyright holder nor the names of its contributors may be
|
|
// used to endorse or promote products derived from this software without specific
|
|
// prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY
|
|
// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
// MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL
|
|
// THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
|
|
// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
|
|
// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
|
|
// THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
#include "carrot_impl/address_device_ram_borrowed.h"
|
|
#include "carrot_impl/carrot_tx_builder_inputs.h"
|
|
#include "carrot_mock_helpers.h"
|
|
#include "cryptonote_basic/cryptonote_basic_impl.h"
|
|
#include "fake_pruned_blockchain.h"
|
|
#include "fcmp_pp/prove.h"
|
|
#include "tx_construction_helpers.h"
|
|
#include "wallet/tx_builder.h"
|
|
|
|
#undef MONERO_DEFAULT_LOG_CATEGORY
|
|
#define MONERO_DEFAULT_LOG_CATEGORY "unit_tests.wallet_scanning"
|
|
|
|
//----------------------------------------------------------------------------------------------------------------------
|
|
TEST(wallet_scanning, view_scan_as_sender_mainaddr)
|
|
{
|
|
cryptonote::account_base aether;
|
|
aether.generate();
|
|
|
|
cryptonote::account_base bob;
|
|
bob.generate();
|
|
const cryptonote::account_public_address bob_main_addr = bob.get_keys().m_account_address;
|
|
const crypto::public_key bob_main_spend_pubkey = bob_main_addr.m_spend_public_key;
|
|
|
|
const rct::xmr_amount amount = rct::randXmrAmount(10 * COIN);
|
|
|
|
const rct::xmr_amount fee = 565678;
|
|
|
|
for (uint8_t hf_version = 1; hf_version < HF_VERSION_FCMP_PLUS_PLUS; ++hf_version)
|
|
{
|
|
MDEBUG("view_scan_as_sender_mainaddr: hf_version=" << static_cast<int>(hf_version));
|
|
|
|
std::vector<cryptonote::tx_destination_entry> destinations{
|
|
cryptonote::tx_destination_entry(amount, bob_main_addr, false)};
|
|
|
|
crypto::secret_key main_tx_privkey;
|
|
std::vector<crypto::secret_key> additional_tx_privkeys;
|
|
const cryptonote::transaction tx = mock::construct_pre_carrot_tx_with_fake_inputs(aether.get_keys(),
|
|
{{aether.get_keys().m_account_address.m_spend_public_key, {0, 0}}},
|
|
{},
|
|
destinations,
|
|
{},
|
|
crypto::null_hash,
|
|
fee,
|
|
hf_version,
|
|
main_tx_privkey,
|
|
additional_tx_privkeys);
|
|
|
|
ASSERT_EQ(0, additional_tx_privkeys.size());
|
|
ASSERT_GT(tx.vout.size(), 0);
|
|
|
|
// do K_d = 8 * r * K^j_v
|
|
crypto::key_derivation main_derivation;
|
|
ASSERT_TRUE(crypto::generate_key_derivation(bob_main_addr.m_view_public_key,
|
|
main_tx_privkey,
|
|
main_derivation));
|
|
|
|
aether.generate();
|
|
|
|
// call view_incoming_scan_transaction with no meaningful key nor subaddresses maps,
|
|
// just with the proper ECDH
|
|
const auto enote_scan_infos = tools::wallet::view_incoming_scan_transaction_as_sender(tx,
|
|
{&main_derivation, 1},
|
|
{},
|
|
bob_main_addr);
|
|
|
|
bool matched = false;
|
|
for (const auto &enote_scan_info : enote_scan_infos)
|
|
{
|
|
if (enote_scan_info)
|
|
{
|
|
ASSERT_FALSE(matched);
|
|
ASSERT_EQ(amount, enote_scan_info->amount);
|
|
ASSERT_EQ(bob_main_spend_pubkey, enote_scan_info->address_spend_pubkey);
|
|
matched = true;
|
|
}
|
|
}
|
|
ASSERT_TRUE(matched);
|
|
}
|
|
}
|
|
//----------------------------------------------------------------------------------------------------------------------
|
|
TEST(wallet_scanning, view_scan_long_payment_id)
|
|
{
|
|
cryptonote::account_base aether;
|
|
aether.generate();
|
|
|
|
cryptonote::account_base bob;
|
|
bob.generate();
|
|
const cryptonote::account_public_address bob_main_addr = bob.get_keys().m_account_address;
|
|
const crypto::public_key bob_main_spend_pubkey = bob_main_addr.m_spend_public_key;
|
|
|
|
const rct::xmr_amount amount = rct::randXmrAmount(10 * COIN);
|
|
|
|
const rct::xmr_amount fee = 565678;
|
|
|
|
const crypto::hash payment_id = crypto::rand<crypto::hash>();
|
|
|
|
for (uint8_t hf_version = 1; hf_version < HF_VERSION_FCMP_PLUS_PLUS; ++hf_version)
|
|
{
|
|
MDEBUG("view_scan_as_sender_mainaddr: hf_version=" << static_cast<int>(hf_version));
|
|
|
|
std::vector<cryptonote::tx_destination_entry> destinations{
|
|
cryptonote::tx_destination_entry(amount, bob_main_addr, false)};
|
|
destinations.front().is_integrated = true;
|
|
|
|
crypto::secret_key main_tx_privkey;
|
|
std::vector<crypto::secret_key> additional_tx_privkeys;
|
|
const cryptonote::transaction tx = mock::construct_pre_carrot_tx_with_fake_inputs(aether.get_keys(),
|
|
{{aether.get_keys().m_account_address.m_spend_public_key, {0, 0}}},
|
|
{},
|
|
destinations,
|
|
{},
|
|
payment_id,
|
|
fee,
|
|
hf_version,
|
|
main_tx_privkey,
|
|
additional_tx_privkeys);
|
|
|
|
ASSERT_EQ(0, additional_tx_privkeys.size());
|
|
ASSERT_GT(tx.vout.size(), 0);
|
|
|
|
// parse tx_extra and check for long payment ID field
|
|
std::vector<cryptonote::tx_extra_field> tx_extra_fields;
|
|
ASSERT_TRUE(cryptonote::parse_tx_extra(tx.extra, tx_extra_fields));
|
|
cryptonote::tx_extra_nonce tx_extra_nonce;
|
|
ASSERT_TRUE(cryptonote::find_tx_extra_field_by_type(tx_extra_fields, tx_extra_nonce));
|
|
crypto::hash parsed_payment_id;
|
|
ASSERT_TRUE(cryptonote::get_payment_id_from_tx_extra_nonce(tx_extra_nonce.nonce, parsed_payment_id));
|
|
ASSERT_EQ(payment_id, parsed_payment_id);
|
|
|
|
// call view_incoming_scan_transaction with no meaningful key nor subaddresses maps,
|
|
// just with the proper ECDH
|
|
std::vector<std::optional<tools::wallet::enote_view_incoming_scan_info_t>> enote_scan_infos(tx.vout.size());
|
|
tools::wallet::view_incoming_scan_transaction(tx,
|
|
bob.get_keys(),
|
|
{{bob_main_spend_pubkey, {}}}, // use a fake subaddress map with just the provided address in it
|
|
epee::to_mut_span(enote_scan_infos));
|
|
|
|
bool matched = false;
|
|
for (const auto &enote_scan_info : enote_scan_infos)
|
|
{
|
|
if (enote_scan_info)
|
|
{
|
|
ASSERT_FALSE(matched);
|
|
ASSERT_EQ(amount, enote_scan_info->amount);
|
|
ASSERT_EQ(bob_main_spend_pubkey, enote_scan_info->address_spend_pubkey);
|
|
ASSERT_EQ(payment_id, enote_scan_info->payment_id);
|
|
matched = true;
|
|
}
|
|
}
|
|
ASSERT_TRUE(matched);
|
|
}
|
|
}
|
|
//----------------------------------------------------------------------------------------------------------------------
|
|
TEST(wallet_scanning, view_scan_short_payment_id)
|
|
{
|
|
cryptonote::account_base aether;
|
|
aether.generate();
|
|
|
|
cryptonote::account_base bob;
|
|
bob.generate();
|
|
const cryptonote::account_public_address bob_main_addr = bob.get_keys().m_account_address;
|
|
const crypto::public_key bob_main_spend_pubkey = bob_main_addr.m_spend_public_key;
|
|
|
|
const rct::xmr_amount amount = rct::randXmrAmount(10 * COIN);
|
|
|
|
const rct::xmr_amount fee = 565678;
|
|
|
|
const crypto::hash8 pid_8 = crypto::rand<crypto::hash8>();
|
|
crypto::hash payment_id = crypto::null_hash;
|
|
memcpy(&payment_id, &pid_8, sizeof(pid_8));
|
|
|
|
ASSERT_FALSE(tools::wallet::is_long_payment_id(payment_id));
|
|
ASSERT_NE(crypto::null_hash, payment_id);
|
|
|
|
for (uint8_t hf_version = 1; hf_version < HF_VERSION_FCMP_PLUS_PLUS; ++hf_version)
|
|
{
|
|
MDEBUG("view_scan_as_sender_mainaddr: hf_version=" << static_cast<int>(hf_version));
|
|
|
|
std::vector<cryptonote::tx_destination_entry> destinations{
|
|
cryptonote::tx_destination_entry(amount, bob_main_addr, false)};
|
|
destinations.front().is_integrated = true;
|
|
|
|
crypto::secret_key main_tx_privkey;
|
|
std::vector<crypto::secret_key> additional_tx_privkeys;
|
|
const cryptonote::transaction tx = mock::construct_pre_carrot_tx_with_fake_inputs(aether.get_keys(),
|
|
{{aether.get_keys().m_account_address.m_spend_public_key, {0, 0}}},
|
|
{},
|
|
destinations,
|
|
{},
|
|
payment_id,
|
|
fee,
|
|
hf_version,
|
|
main_tx_privkey,
|
|
additional_tx_privkeys);
|
|
|
|
ASSERT_EQ(0, additional_tx_privkeys.size());
|
|
ASSERT_GT(tx.vout.size(), 0);
|
|
|
|
// parse tx_extra and check that a short payment ID field exists
|
|
std::vector<cryptonote::tx_extra_field> tx_extra_fields;
|
|
ASSERT_TRUE(cryptonote::parse_tx_extra(tx.extra, tx_extra_fields));
|
|
cryptonote::tx_extra_nonce tx_extra_nonce;
|
|
ASSERT_TRUE(cryptonote::find_tx_extra_field_by_type(tx_extra_fields, tx_extra_nonce));
|
|
crypto::hash8 pid_enc_8;
|
|
ASSERT_TRUE(cryptonote::get_encrypted_payment_id_from_tx_extra_nonce(tx_extra_nonce.nonce, pid_enc_8));
|
|
|
|
// call view_incoming_scan_transaction with no meaningful key nor subaddresses maps,
|
|
// just with the proper ECDH
|
|
std::vector<std::optional<tools::wallet::enote_view_incoming_scan_info_t>> enote_scan_infos(tx.vout.size());
|
|
tools::wallet::view_incoming_scan_transaction(tx,
|
|
bob.get_keys(),
|
|
{{bob_main_spend_pubkey, {}}}, // use a fake subaddress map with just the provided address in it
|
|
epee::to_mut_span(enote_scan_infos));
|
|
|
|
bool matched = false;
|
|
for (const auto &enote_scan_info : enote_scan_infos)
|
|
{
|
|
if (enote_scan_info)
|
|
{
|
|
ASSERT_FALSE(matched);
|
|
ASSERT_EQ(amount, enote_scan_info->amount);
|
|
ASSERT_EQ(bob_main_spend_pubkey, enote_scan_info->address_spend_pubkey);
|
|
ASSERT_EQ(payment_id, enote_scan_info->payment_id);
|
|
matched = true;
|
|
}
|
|
}
|
|
ASSERT_TRUE(matched);
|
|
}
|
|
}
|
|
//----------------------------------------------------------------------------------------------------------------------
|
|
TEST(wallet_scanning, positive_smallout_main_addr_all_types_outputs)
|
|
{
|
|
// Test that wallet can scan and recover enotes of following type:
|
|
// a. pre-ringct coinbase
|
|
// b. pre-ringct
|
|
// c. ringct coinbase
|
|
// d. ringct long-amount
|
|
// e. ringct short-amount
|
|
// f. view-tagged ringct coinbase
|
|
// g. view-tagged pre-ringct (only possible in unmixable sweep txs)
|
|
// h. view-tagged ringct
|
|
// i. carrot v1 coinbase
|
|
// j. carrot v1 normal
|
|
// k. carrot v1 special
|
|
// l. carrot v1 internal (@TODO)
|
|
//
|
|
// All enotes are addressed to the main address in 2-out noin-coinbase txs or 1-out coinbase txs.
|
|
// We also don't test reorgs here.
|
|
|
|
// init blockchain
|
|
mock::fake_pruned_blockchain bc(0);
|
|
|
|
// generate wallet
|
|
tools::wallet2 w(cryptonote::MAINNET, /*kdf_rounds=*/1, /*unattended=*/true);
|
|
w.generate("", "");
|
|
const cryptonote::account_keys &acc_keys = w.get_account().get_keys();
|
|
const cryptonote::account_public_address main_addr = w.get_account().get_keys().m_account_address;
|
|
ASSERT_EQ(0, w.balance(0, true));
|
|
bc.init_wallet_for_starting_block(w); // needed b/c internal logic
|
|
|
|
uint64_t refresh_height = 0;
|
|
const auto wallet_process_new_blocks = [&w, &bc, &refresh_height]() -> boost::multiprecision::int128_t
|
|
{
|
|
const boost::multiprecision::int128_t old_balance = w.balance(0, true);
|
|
|
|
// note: doesn't handle reorgs
|
|
std::vector<cryptonote::block_complete_entry> block_entries;
|
|
std::vector<tools::wallet2::parsed_block> parsed_blocks;
|
|
bc.get_blocks_data(0, bc.height()-1, block_entries, parsed_blocks); //! @TODO: figure out why starting from refresh_height doesn't work
|
|
uint64_t blocks_added{};
|
|
auto output_tracker_cache = w.create_output_tracker_cache();
|
|
w.process_parsed_blocks(0, block_entries, parsed_blocks, blocks_added, output_tracker_cache);
|
|
|
|
// update refresh_height
|
|
refresh_height = bc.height();
|
|
|
|
// return amount of money received
|
|
return boost::multiprecision::int128_t(w.balance(0, true)) - old_balance;
|
|
};
|
|
|
|
// a. push block containing a pre-ringct coinbase output to wallet
|
|
bc.add_block(1, {}, main_addr);
|
|
|
|
// a. scan pre-ringct coinbase tx
|
|
auto balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(mock::fake_pruned_blockchain::miner_reward, balance_diff);
|
|
EXPECT_TRUE(verify_sals_of_recent_transfers());
|
|
|
|
// b. construct and push a pre-ringct tx
|
|
const rct::xmr_amount amount_b = rct::randXmrAmount(COIN);
|
|
{
|
|
const rct::xmr_amount fee = rct::randXmrAmount(COIN);
|
|
std::vector<cryptonote::tx_destination_entry> dests = {
|
|
cryptonote::tx_destination_entry(amount_b, acc_keys.m_account_address, false)};
|
|
cryptonote::transaction curr_tx = mock::construct_pre_carrot_tx_with_fake_inputs(
|
|
acc_keys,
|
|
w.m_subaddresses,
|
|
/*stripped_sources=*/{},
|
|
dests,
|
|
acc_keys.m_account_address,
|
|
fee,
|
|
/*hf_version=*/1);
|
|
ASSERT_FALSE(cryptonote::is_coinbase(curr_tx));
|
|
ASSERT_EQ(1, curr_tx.version);
|
|
ASSERT_EQ(rct::RCTTypeNull, curr_tx.rct_signatures.type);
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_key), curr_tx.vout.at(0).target.type());
|
|
ASSERT_EQ(amount_b, curr_tx.vout.at(0).amount);
|
|
bc.add_block(1, {std::move(curr_tx)}, mock::null_addr);
|
|
}
|
|
|
|
// b. scan pre-ringct tx
|
|
balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(amount_b, balance_diff);
|
|
|
|
// c. construct and push a ringct coinbase tx
|
|
bc.add_block(HF_VERSION_DYNAMIC_FEE, {}, main_addr);
|
|
{
|
|
auto top_block = bc.get_parsed_block(bc.height() - 1);
|
|
const cryptonote::transaction &top_miner_tx = top_block.block.miner_tx;
|
|
ASSERT_EQ(2, top_miner_tx.version);
|
|
ASSERT_NE(0, top_miner_tx.vout.size());
|
|
ASSERT_EQ(rct::RCTTypeNull, top_miner_tx.rct_signatures.type);
|
|
ASSERT_EQ(0, top_miner_tx.signatures.size());
|
|
ASSERT_EQ(mock::fake_pruned_blockchain::miner_reward, top_miner_tx.vout.at(0).amount);
|
|
}
|
|
|
|
// c. scan ringct coinbase tx
|
|
balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(mock::fake_pruned_blockchain::miner_reward, balance_diff);
|
|
EXPECT_TRUE(verify_sals_of_recent_transfers());
|
|
|
|
// d. construct and push a ringct long-amount tx
|
|
const rct::xmr_amount amount_d = rct::randXmrAmount(COIN);
|
|
{
|
|
const rct::xmr_amount fee = rct::randXmrAmount(COIN);
|
|
std::vector<cryptonote::tx_destination_entry> dests = {
|
|
cryptonote::tx_destination_entry(amount_d, acc_keys.m_account_address, false)};
|
|
cryptonote::transaction curr_tx = mock::construct_pre_carrot_tx_with_fake_inputs(
|
|
acc_keys,
|
|
w.m_subaddresses,
|
|
/*stripped_sources=*/{},
|
|
dests,
|
|
acc_keys.m_account_address,
|
|
fee,
|
|
HF_VERSION_DYNAMIC_FEE);
|
|
ASSERT_FALSE(cryptonote::is_coinbase(curr_tx));
|
|
ASSERT_EQ(2, curr_tx.version);
|
|
ASSERT_EQ(rct::RCTTypeFull, curr_tx.rct_signatures.type);
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_key), curr_tx.vout.at(0).target.type());
|
|
ASSERT_EQ(0, curr_tx.vout.at(0).amount);
|
|
bc.add_block(HF_VERSION_DYNAMIC_FEE, {std::move(curr_tx)}, mock::null_addr);
|
|
}
|
|
|
|
// d. scan ringct long-amount tx
|
|
balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(amount_d, balance_diff);
|
|
|
|
// e. construct and push a ringct short-amount tx
|
|
const rct::xmr_amount amount_e = rct::randXmrAmount(COIN);
|
|
{
|
|
const rct::xmr_amount fee = rct::randXmrAmount(COIN);
|
|
std::vector<cryptonote::tx_destination_entry> dests = {
|
|
cryptonote::tx_destination_entry(amount_e, acc_keys.m_account_address, false)};
|
|
cryptonote::transaction curr_tx = mock::construct_pre_carrot_tx_with_fake_inputs(
|
|
acc_keys,
|
|
w.m_subaddresses,
|
|
/*stripped_sources=*/{},
|
|
dests,
|
|
acc_keys.m_account_address,
|
|
fee,
|
|
HF_VERSION_SMALLER_BP);
|
|
ASSERT_FALSE(cryptonote::is_coinbase(curr_tx));
|
|
ASSERT_EQ(2, curr_tx.version);
|
|
ASSERT_EQ(rct::RCTTypeBulletproof2, curr_tx.rct_signatures.type);
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_key), curr_tx.vout.at(0).target.type());
|
|
ASSERT_EQ(0, curr_tx.vout.at(0).amount);
|
|
bc.add_block(HF_VERSION_SMALLER_BP, {std::move(curr_tx)}, mock::null_addr);
|
|
}
|
|
|
|
// e. scan ringct short-amount tx
|
|
balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(amount_e, balance_diff);
|
|
|
|
// f. construct and push a view-tagged ringct coinbase tx
|
|
bc.add_block(HF_VERSION_VIEW_TAGS, {}, main_addr);
|
|
{
|
|
auto top_block = bc.get_parsed_block(bc.height() - 1);
|
|
const cryptonote::transaction &top_miner_tx = top_block.block.miner_tx;
|
|
ASSERT_EQ(2, top_miner_tx.version);
|
|
ASSERT_EQ(1, top_miner_tx.vout.size());
|
|
ASSERT_EQ(rct::RCTTypeNull, top_miner_tx.rct_signatures.type);
|
|
ASSERT_EQ(0, top_miner_tx.signatures.size());
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_tagged_key), top_miner_tx.vout.at(0).target.type());
|
|
ASSERT_EQ(mock::fake_pruned_blockchain::miner_reward, top_miner_tx.vout.at(0).amount);
|
|
}
|
|
|
|
// f. scan view-tagged ringct coinbase tx
|
|
balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(mock::fake_pruned_blockchain::miner_reward, balance_diff);
|
|
EXPECT_TRUE(verify_sals_of_recent_transfers());
|
|
|
|
// g. construct and push a view-tagged pre-ringct (only possible in unmixable sweep txs) tx
|
|
const rct::xmr_amount amount_g = rct::randXmrAmount(COIN);
|
|
{
|
|
const rct::xmr_amount fee = rct::randXmrAmount(COIN);
|
|
std::vector<cryptonote::tx_destination_entry> dests = {
|
|
cryptonote::tx_destination_entry(amount_g, acc_keys.m_account_address, false)};
|
|
cryptonote::transaction curr_tx = mock::construct_pre_carrot_tx_with_fake_inputs(
|
|
acc_keys,
|
|
w.m_subaddresses,
|
|
/*stripped_sources=*/{},
|
|
dests,
|
|
acc_keys.m_account_address,
|
|
fee,
|
|
HF_VERSION_VIEW_TAGS,
|
|
/*sweep_unmixable_override=*/true);
|
|
ASSERT_FALSE(cryptonote::is_coinbase(curr_tx));
|
|
ASSERT_EQ(1, curr_tx.version);
|
|
ASSERT_EQ(rct::RCTTypeNull, curr_tx.rct_signatures.type);
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_tagged_key), curr_tx.vout.at(0).target.type());
|
|
ASSERT_EQ(amount_g, curr_tx.vout.at(0).amount);
|
|
bc.add_block(HF_VERSION_VIEW_TAGS, {std::move(curr_tx)}, mock::null_addr);
|
|
}
|
|
|
|
// g. scan view-tagged pre-ringct (only possible in unmixable sweep txs) tx
|
|
balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(amount_g, balance_diff);
|
|
|
|
// h. construct and push a view-tagged ringct tx
|
|
const rct::xmr_amount amount_h = rct::randXmrAmount(COIN);
|
|
{
|
|
const rct::xmr_amount fee = rct::randXmrAmount(COIN);
|
|
std::vector<cryptonote::tx_destination_entry> dests = {
|
|
cryptonote::tx_destination_entry(amount_h, acc_keys.m_account_address, false)};
|
|
cryptonote::transaction curr_tx = mock::construct_pre_carrot_tx_with_fake_inputs(
|
|
acc_keys,
|
|
w.m_subaddresses,
|
|
/*stripped_sources=*/{},
|
|
dests,
|
|
acc_keys.m_account_address,
|
|
fee,
|
|
HF_VERSION_VIEW_TAGS);
|
|
ASSERT_FALSE(cryptonote::is_coinbase(curr_tx));
|
|
ASSERT_EQ(2, curr_tx.version);
|
|
ASSERT_EQ(rct::RCTTypeBulletproofPlus, curr_tx.rct_signatures.type);
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_tagged_key), curr_tx.vout.at(0).target.type());
|
|
ASSERT_EQ(0, curr_tx.vout.at(0).amount);
|
|
bc.add_block(HF_VERSION_VIEW_TAGS, {std::move(curr_tx)}, mock::null_addr);
|
|
}
|
|
|
|
// h. scan ringct view-tagged ringct tx
|
|
balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(amount_h, balance_diff);
|
|
|
|
// i. construct and push a carrot v1 coinbase tx
|
|
bc.add_block(HF_VERSION_CARROT, {}, main_addr);
|
|
{
|
|
auto top_block = bc.get_parsed_block(bc.height() - 1);
|
|
const cryptonote::transaction &top_miner_tx = top_block.block.miner_tx;
|
|
ASSERT_EQ(2, top_miner_tx.version);
|
|
ASSERT_EQ(1, top_miner_tx.vout.size());
|
|
ASSERT_EQ(rct::RCTTypeNull, top_miner_tx.rct_signatures.type);
|
|
ASSERT_EQ(0, top_miner_tx.signatures.size());
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_carrot_v1), top_miner_tx.vout.at(0).target.type());
|
|
ASSERT_EQ(mock::fake_pruned_blockchain::miner_reward, top_miner_tx.vout.at(0).amount);
|
|
}
|
|
|
|
// i. scan carrot v1 coinbase tx
|
|
balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(mock::fake_pruned_blockchain::miner_reward, balance_diff);
|
|
EXPECT_TRUE(verify_sals_of_recent_transfers());
|
|
|
|
// j. construct and push a carrot v1 normal tx
|
|
const rct::xmr_amount amount_j = rct::randXmrAmount(COIN);
|
|
{
|
|
std::vector<cryptonote::tx_destination_entry> dests = {
|
|
cryptonote::tx_destination_entry(amount_j, acc_keys.m_account_address, false)};
|
|
cryptonote::transaction curr_tx = mock::construct_carrot_pruned_transaction_fake_inputs(
|
|
{carrot::mock::convert_normal_payment_proposal_v1(dests.front())},
|
|
/*selfsend_payment_proposals=*/{},
|
|
acc_keys);
|
|
ASSERT_FALSE(cryptonote::is_coinbase(curr_tx));
|
|
ASSERT_EQ(2, curr_tx.version);
|
|
ASSERT_EQ(rct::RCTTypeFcmpPlusPlus, curr_tx.rct_signatures.type);
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_carrot_v1), curr_tx.vout.at(0).target.type());
|
|
ASSERT_EQ(0, curr_tx.vout.at(0).amount);
|
|
bc.add_block(HF_VERSION_CARROT, {std::move(curr_tx)}, mock::null_addr);
|
|
}
|
|
|
|
// j. scan carrot v1 normal tx
|
|
balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(amount_j, balance_diff);
|
|
|
|
// k. construct and push a carrot v1 special tx
|
|
const rct::xmr_amount amount_k = rct::randXmrAmount(COIN);
|
|
{
|
|
std::vector<cryptonote::tx_destination_entry> dests = {
|
|
cryptonote::tx_destination_entry(amount_k, acc_keys.m_account_address, false)};
|
|
cryptonote::transaction curr_tx = mock::construct_carrot_pruned_transaction_fake_inputs(
|
|
/*normal_payment_proposals=*/{},
|
|
{{carrot::mock::convert_selfsend_payment_proposal_v1(dests.front()), {/*main*/}}},
|
|
acc_keys);
|
|
ASSERT_FALSE(cryptonote::is_coinbase(curr_tx));
|
|
ASSERT_EQ(2, curr_tx.version);
|
|
ASSERT_EQ(rct::RCTTypeFcmpPlusPlus, curr_tx.rct_signatures.type);
|
|
ASSERT_EQ(2, curr_tx.vout.size());
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_carrot_v1), curr_tx.vout.at(0).target.type());
|
|
ASSERT_EQ(0, curr_tx.vout.at(0).amount);
|
|
bc.add_block(HF_VERSION_CARROT, {std::move(curr_tx)}, mock::null_addr);
|
|
}
|
|
|
|
// k. scan carrot v1 special tx
|
|
balance_diff = wallet_process_new_blocks();
|
|
EXPECT_EQ(amount_k, balance_diff);
|
|
}
|
|
//----------------------------------------------------------------------------------------------------------------------
|
|
TEST(wallet_scanning, burned_zombie)
|
|
{
|
|
// Check that a wallet which receives attempted burn outputs counts all outputs of the same key
|
|
// image spent when that key image is spent. Those with the same key image which aren't marked
|
|
// as spent are "burned zombies": they aren't burn and not usable, but they shuffle around in
|
|
// the internal state and inflate the balance or attract input selection.
|
|
|
|
// init blockchain
|
|
mock::fake_pruned_blockchain bc(0);
|
|
|
|
// generate wallet
|
|
tools::wallet2 w(cryptonote::MAINNET, /*kdf_rounds=*/1, /*unattended=*/true);
|
|
w.set_offline(true);
|
|
w.generate("", "");
|
|
const cryptonote::account_keys &acc_keys = w.get_account().get_keys();
|
|
const cryptonote::account_public_address main_addr = w.get_account().get_keys().m_account_address;
|
|
ASSERT_EQ(0, w.balance(0, true));
|
|
bc.init_wallet_for_starting_block(w); // needed b/c internal logic
|
|
|
|
const rct::xmr_amount amount_a = rct::randXmrAmount(COIN) + 1;
|
|
const rct::xmr_amount amount_b = rct::randXmrAmount(amount_a - 1);
|
|
const rct::xmr_amount fee = rct::randXmrAmount(COIN);
|
|
|
|
// make incoming pre-ringct tx to wallet with amount a
|
|
cryptonote::transaction incoming_tx_a;
|
|
{
|
|
std::vector<cryptonote::tx_destination_entry> dests = {
|
|
cryptonote::tx_destination_entry(amount_a, main_addr, false)};
|
|
incoming_tx_a = mock::construct_pre_carrot_tx_with_fake_inputs(
|
|
dests,
|
|
fee,
|
|
/*hf_version=*/1);
|
|
ASSERT_FALSE(cryptonote::is_coinbase(incoming_tx_a));
|
|
ASSERT_EQ(1, incoming_tx_a.version);
|
|
ASSERT_EQ(rct::RCTTypeNull, incoming_tx_a.rct_signatures.type);
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_key), incoming_tx_a.vout.at(0).target.type());
|
|
ASSERT_EQ(amount_a, incoming_tx_a.vout.at(0).amount);
|
|
}
|
|
|
|
// make a burn transaction with amount b < a
|
|
cryptonote::transaction incoming_tx_b = incoming_tx_a;
|
|
boost::get<cryptonote::txin_to_key>(incoming_tx_b.vin.at(0)).k_image = rct::rct2ki(rct::pkGen());
|
|
incoming_tx_b.vout[0].amount = amount_b;
|
|
|
|
// submit burning transaction first
|
|
bc.add_block(1, {incoming_tx_b}, mock::null_addr);
|
|
|
|
// then submit original transaction
|
|
bc.add_block(1, {incoming_tx_a}, mock::null_addr);
|
|
|
|
// add 10 blocks to put space between sending outgoing tx
|
|
const cryptonote::tx_out dummy_output{.amount = 5, .target = cryptonote::txout_to_key(rct::rct2pk(rct::pkGen()))};
|
|
cryptonote::transaction dummy_tx; //! @TODO: remove dummy as prop fixing another bug
|
|
dummy_tx.version = 1;
|
|
dummy_tx.unlock_time = 0;
|
|
dummy_tx.vout.push_back(dummy_output);
|
|
for (size_t i = 0; i <= CRYPTONOTE_DEFAULT_TX_SPENDABLE_AGE; ++i)
|
|
bc.add_block(1, {dummy_tx}, mock::null_addr);
|
|
|
|
// scan, assert balance is amount a, (NOT a + b) and get key image to received output
|
|
bc.refresh_wallet(w, 0);
|
|
ASSERT_EQ(amount_a, w.balance_all(true));
|
|
uint64_t key_image_offset;
|
|
std::vector<std::pair<crypto::key_image, crypto::signature>> exported_key_images;
|
|
std::tie(key_image_offset, exported_key_images) = w.export_key_images(/*all=*/true);
|
|
ASSERT_EQ(0, key_image_offset);
|
|
ASSERT_EQ(2, exported_key_images.size());
|
|
const crypto::key_image &received_key_image = exported_key_images.at(0).first;
|
|
ASSERT_EQ(received_key_image, exported_key_images.at(1).first);
|
|
|
|
// make "outgoing" transaction by including this key image in an input
|
|
cryptonote::transaction outgoing_tx;
|
|
{
|
|
const rct::xmr_amount outgoing_amount = rct::randXmrAmount(amount_a);
|
|
const rct::xmr_amount outgoing_fee = amount_a - outgoing_amount;
|
|
std::vector<cryptonote::tx_destination_entry> dests = {
|
|
cryptonote::tx_destination_entry(outgoing_amount, mock::null_addr, false)};
|
|
crypto::secret_key main_tx_privkey;
|
|
std::vector<crypto::secret_key> additional_tx_privkeys;
|
|
tools::wallet2::transfer_container transfers;
|
|
w.get_transfers(transfers);
|
|
ASSERT_EQ(2, transfers.size());
|
|
const tools::wallet2::transfer_details &input_td = transfers.at(1);
|
|
const mock::stripped_down_tx_source_entry_t input_src{
|
|
.is_rct = false,
|
|
.global_output_index = input_td.m_global_output_index,
|
|
.onetime_address = input_td.get_public_key(),
|
|
.real_out_tx_key = cryptonote::get_tx_pub_key_from_extra(input_td.m_tx, input_td.m_pk_index),
|
|
.local_output_index = 0,
|
|
.amount = amount_a,
|
|
.mask = rct::I
|
|
};
|
|
outgoing_tx = mock::construct_pre_carrot_tx_with_fake_inputs(acc_keys,
|
|
w.m_subaddresses,
|
|
{input_src},
|
|
dests,
|
|
/*change_addr=*/{},
|
|
crypto::null_hash,
|
|
outgoing_fee,
|
|
/*hf_version=*/1,
|
|
main_tx_privkey,
|
|
additional_tx_privkeys);
|
|
ASSERT_FALSE(cryptonote::is_coinbase(outgoing_tx));
|
|
ASSERT_EQ(1, outgoing_tx.version);
|
|
ASSERT_EQ(1, outgoing_tx.vin.size());
|
|
ASSERT_EQ(1, outgoing_tx.vout.size());
|
|
ASSERT_EQ(received_key_image, boost::get<cryptonote::txin_to_key>(outgoing_tx.vin.at(0)).k_image);
|
|
ASSERT_EQ(rct::RCTTypeNull, outgoing_tx.rct_signatures.type);
|
|
ASSERT_EQ(typeid(cryptonote::txout_to_key), outgoing_tx.vout.at(0).target.type());
|
|
ASSERT_EQ(amount_a, boost::get<cryptonote::txin_to_key>(outgoing_tx.vin.at(0)).amount);
|
|
ASSERT_EQ(outgoing_amount, outgoing_tx.vout.at(0).amount);
|
|
ASSERT_EQ(outgoing_fee, cryptonote::get_tx_fee(outgoing_tx));
|
|
}
|
|
|
|
// add outgoing tx to chain and wallet scans it
|
|
bc.add_block(1, {outgoing_tx}, mock::null_addr);
|
|
bc.refresh_wallet(w, 0);
|
|
|
|
// check that the balance drops to 0 and that all transfers are marked spent
|
|
ASSERT_EQ(0, w.balance_all(true));
|
|
tools::wallet2::transfer_container post_spend_transfers;
|
|
w.get_transfers(post_spend_transfers);
|
|
ASSERT_EQ(2, post_spend_transfers.size());
|
|
for (const tools::wallet2::transfer_details &td : post_spend_transfers)
|
|
ASSERT_TRUE(td.m_spent);
|
|
}
|
|
//----------------------------------------------------------------------------------------------------------------------
|